Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Embedded webextension isolated new - #11800

Merged
jsha merged 3 commits into
EFForg:masterfrom
Hainish:embedded-webextension-isolated-new
Aug 10, 2017
Merged

jsha merged 3 commits into
EFForg:masterfrom
Hainish:embedded-webextension-isolated-new

Conversation

@Hainish

@Hainish Hainish commented Aug 10, 2017

Copy link
Copy Markdown
Member

No description provided.

@Hainish

Hainish commented Aug 10, 2017

Copy link
Copy Markdown
Member Author

If everything looks good you can pull the trigger and merge this, @jsha

Comment thread makexpi.sh Outdated
python2.7 utils/chromium-translations.py src/chrome/locale/ pkg/xpi-eff/webextension/_locales/

do_not_ship="*.py *.xml icon.jpg"
rm -f pkg/xpi-eff/webextension/$do_not_ship

@jsha jsha Aug 10, 2017 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong; it will delete *.xml and icon.jpg in the current directory. Instead just add one line per thing. Or possibly delete this line? It seems like it's been broken, but hasn't had an ill effect.

@Hainish

Hainish commented Aug 10, 2017 via email

Copy link
Copy Markdown
Member Author

@jsha

jsha commented Aug 10, 2017

Copy link
Copy Markdown
Member

Look closely:

makecrx:

do_not_ship="*.py *.xml icon.jpg"
rm -f $do_not_ship
do_not_ship="*.py *.xml icon.jpg"
rm -f pkg/xpi-eff/webextension/$do_not_ship

Bash does not repeat the prefix on the do_not_ship variable.

@Hainish

Hainish commented Aug 10, 2017 via email

Copy link
Copy Markdown
Member Author

@Hainish

Hainish commented Aug 10, 2017

Copy link
Copy Markdown
Member Author

@jsha fixed

@jsha
jsha merged commit ad3d311 into EFForg:master Aug 10, 2017
@Hainish

Hainish commented Aug 10, 2017

Copy link
Copy Markdown
Member Author

Woohooo!

@ghost

ghost commented Aug 10, 2017

Copy link
Copy Markdown

Yeah!

@ghost

ghost commented Aug 10, 2017

Copy link
Copy Markdown

@Hainish See #11807.

@Hainish
Hainish deleted the embedded-webextension-isolated-new branch February 23, 2018 01:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants